Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DB] Remove unused variable #21716

Merged
merged 1 commit into from
Mar 14, 2019
Merged

[DB] Remove unused variable #21716

merged 1 commit into from
Mar 14, 2019

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR removes the unused $columns variable

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from rogyar March 12, 2019 13:16
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: DB Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 12, 2019
@eduard13 eduard13 changed the title [Framework] Remove unused variable [DB] Remove unused variable Mar 12, 2019
@ihor-sviziev ihor-sviziev self-assigned this Mar 12, 2019
@ihor-sviziev ihor-sviziev removed the request for review from rogyar March 12, 2019 13:20
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4483 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 13, 2019
@soleksii
Copy link

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Mar 13, 2019
@magento-engcom-team magento-engcom-team merged commit a7a14d0 into magento:2.3-develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 14, 2019
@sidolov
ENGCOM-4483: [DB] Remove unused variable #21716
f69cfd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@p-bystritsky p-bystritsky

@soleksii soleksii

Labels
Cleanup Component: DB Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@eduard13 @magento-engcom-team @soleksii @ihor-sviziev @p-bystritsky